Skip to content

Conversation

@cptartur
Copy link
Member

@cptartur cptartur commented Nov 7, 2025

@cptartur cptartur force-pushed the spr/master/93f11ecb branch from af33d6c to cb09e64 Compare November 7, 2025 11:23
@cptartur cptartur force-pushed the spr/master/743274ba branch 2 times, most recently from 61dec7f to d7781bd Compare November 7, 2025 11:29
@cptartur cptartur force-pushed the spr/master/93f11ecb branch 2 times, most recently from 39d7741 to 9662b7c Compare November 7, 2025 11:31
@cptartur cptartur force-pushed the spr/master/743274ba branch from d7781bd to a9d4e9b Compare November 7, 2025 11:31
@cptartur cptartur marked this pull request as ready for review November 7, 2025 11:51
@cptartur cptartur requested a review from a team as a code owner November 7, 2025 11:51
@cptartur cptartur requested review from MKowalski8 and ksew1 and removed request for a team November 7, 2025 11:51
@cptartur cptartur force-pushed the spr/master/743274ba branch from a9d4e9b to 6fc23a5 Compare November 12, 2025 12:23
commit-id:743274ba
scarb-version:
description: 'Optional: Scarb version to install. If not set, uses version from .tool-versions'
required: false
default: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why default value isn't a proper scarb version? Perhaps we could use a minimal supported version here.

non_exact_gas_assertions = []
skip_test_for_only_latest_scarb = []
skip_test_for_scarb_since_2_11 = []
run_test_for_scarb_since_2_13 = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch version indeed matters in this case, as oracles don't work with 2.13.0:

Suggested change
run_test_for_scarb_since_2_13 = []
run_test_for_scarb_since_2_13_1 = []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants